[MESOS-8906] `UriDiskProfileAdaptor` fails to update profile selectors.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.0, 1.6.0
• Fix Version/s: 1.5.2, 1.6.1, 1.7.0
• Component/s: storage
• Labels: mesosphere storage
• Target Version/s: 1.5.2, 1.6.1, 1.7.0
• Epic Link: Resource Provider and CSI Tech Debt
• Sprint: Mesosphere Sprint 2018-20
• Story Points: 2
• Assignee: Chun-Hung Hsiao
• Reporter: Chun-Hung Hsiao
• Shepherd: Jie Yu
• Created: 11/May/18 03:23
• Updated: 14/Jun/18 20:10
• Resolved: 11/May/18 23:35

Description

The UriDiskProfileAdaptor ignores the polled profile matrix if the polled one has the same size as the current one: https://github.com/apache/mesos/blob/1.5.x/src/resource_provider/storage/uri_disk_profile.cpp#L282-L286

Unable to find source-code formatter for language: cxx. Available languages are: actionscript, ada, applescript, bash, c, c#, c++, cpp, css, erlang, go, groovy, haskell, html, java, javascript, js, json, lua, none, nyan, objc, perl, php, python, r, rainbow, ruby, scala, sh, sql, swift, visualbasic, xml, yaml

  // Profiles can only be added, so if the parsed data is the same size,
  // nothing has changed and no notifications need to be sent.
  if (parsed.profile_matrix().size() <= profileMatrix.size()) {
    return;
  }

However, this prevents the profile selector from being updated, which is not the desired behavior.