[MESOS-8857] Fix subprocess(flags) logic on Windows to handle arguments with quotes

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Labels: flags libprocess windows
• Epic Link: windows-libprocess-tests
• Assignee: Radhika Jandhyala
• Reporter: Andrew Schwartzmeyer
• Created: 01/May/18 22:37
• Updated: 16/May/18 18:47
• Resolved: 16/May/18 18:47

Description

In the SubprocessTest.Flags unit test, a bug was discovered where the flags argument flags.s3 = "\"geek\""; does not make it round-trip back to the test. It is because the stringify_args logic in shell.hpp purposefully (correctly?) surrounds an argument that contains a double quote with a pair of double quotes. Thus the final command-line flag looks like "\"--s3=\\\"geek\\\"\"", which flags.load() then fails to reparse. The same problem occurs for the (more complicated) JSON flag.

I believe this is because the original logic was expecting the shell to drop the quotes (echo "-s3=\"geek\"" in Bash returns s3="geek", but cmd.exe echos "-s3=\"geek\"", exactly what was passed. Maybe the test just needs to be fixed; maybe the stringifier shouldn't add more quotes; maybe flags.load() needs to parse the quotes and escapes.

For now, we're enabling the rest of the test by turning off those two checks.

Issue Links

• links to: GitHub Pull Request #288
• links to: GitHub Pull Request #289