[MESOS-8670] Implement `process::io::read/write` using Thread Pool API

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Labels: libprocess windows
• Target Version/s: 1.7.0
• Epic Link: libprocess-iocp
• Assignee: Akash Gupta
• Reporter: Akash Gupta
• Shepherd: Andrew Schwartzmeyer
• Created: 13/Mar/18 23:14
• Updated: 23/May/18 21:40
• Resolved: 23/May/18 21:40

Description

process::io::read/write currently use a read/write loop with io:: poll, which is implemented by the libevent loop. This doesn't work on Windows, because libevent only works on sockets. Furthermore, the reads/writes are blocking on Windows for pipes. Instead, we should use I/O completion ports with overlapped I/O and the thread pool API to implement read/write.

Note: when read/write receive a file/socket/pipe handle in overlapped mode, they will assign them to the IOCP handle. The stout function os::nonblock will (continue to) be a no-op on Windows. It does not make sense to make os::nonblock do the association, as the IOCP handle is a global in libprocess, of which stout has no knowledge.

Issue Links

• is blocked by: MESOS-8673 Fix os::open to use HANDLEs
• is blocked by: MESOS-8676 Fix os::read and os::write to use HANDLES