[MESOS-8631] Agent should be able to start a task with every CPU on a Windows machine

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.5.1, 1.6.0
• Labels: cpu isolator windows

Environment

Windows 10 using the CPU isolator

• Target Version/s: 1.5.1, 1.6.0
• Assignee: Andrew Schwartzmeyer
• Reporter: Andrew Schwartzmeyer
• Created: 02/Mar/18 23:20
• Updated: 05/Mar/18 22:17
• Resolved: 05/Mar/18 20:58

Description

We have an edge case that existing unit tests don't cover: starting a single task which consumes every reported CPU. The problem is that the executor overcommits by 0.1 CPUs, so when we go to set the CPU limit, on say a 12 core machine, we set it to 12.1/12 * 10000 CPU cycles, which results in an invalid number of cycles (10,083, but the max is 10,000).

We were bounds-checking the minimum (1 cycle) but not the maximum, as the function did not expect the user to request more CPUs than available.

We'll fix this by checking the max bound. So if, for example, 12.1 CPUs are requested, re set the limit to 10000 CPU cycles, no more.

Issue Links

• is related to: MESOS-8632 Add unit tests which exercise resources dynamically