[MESOS-8619] Docker on Windows uses USERPROFILE instead of HOME for credentials

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.5.1, 1.6.0
• Labels: docker windows

Environment

Windows 10 with Docker version 17.12.0-ce, build c97c6d6.

• Target Version/s: 1.5.1, 1.6.0
• Assignee: Andrew Schwartzmeyer
• Reporter: Andrew Schwartzmeyer
• Created: 27/Feb/18 18:04
• Updated: 05/Mar/18 22:17
• Resolved: 02/Mar/18 18:21

Description

The logic for doing a docker pull of an image for a private registry assumes that the .docker/config.json is to be found in $HOME (according to the Mesosphere instructions and the code).

However, this assumption was only true for Linux per the Docker code, but on Windows, Docker explicitly looks at the USERPROFILE environment variable, again per the Docker code.

So in order for Docker to pick up the config file correctly, we need to change the variable used on Windows in the Docker containerizer.