[MESOS-8537] Default executor doesn't wait for status updates to be ack'd before shutting down

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.1, 1.5.0
• Fix Version/s: 1.5.4, 1.6.3, 1.7.3, 1.8.2, 1.9.1, 1.10.0
• Component/s: executor
• Labels: containerization default-executor mesosphere
• Epic Link: Default Executor improvements
• Sprint: Containerization: RI-16 Sp 50
• Story Points: 3
• Assignee: Andrei Budnik
• Reporter: Gastón Kleiman
• Created: 02/Feb/18 20:38
• Updated: 19/Mar/20 22:31
• Resolved: 03/Feb/20 15:56

Description

The default executor doesn't wait for pending status updates to be acknowledged before shutting down, instead it sleeps for one second and then terminates:

  void _shutdown()
  {
    const Duration duration = Seconds(1);

    LOG(INFO) << "Terminating after " << duration;

    // TODO(qianzhang): Remove this hack since the executor now receives
    // acknowledgements for status updates. The executor can terminate
    // after it receives an ACK for a terminal status update.
    os::sleep(duration);
    terminate(self());
  }

The event handler should exit if upon receiving a Event::ACKNOWLEDGED the executor is shutting down, no tasks are running anymore, and all pending status updates have been acknowledged.

Issue Links

• is related to: MESOS-9847 Docker executor doesn't wait for status updates to be ack'd before shutting down.