[MESOS-8513] Noisy "transport endpoint is not connected" logs on closing sockets.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4.1, 1.5.0, 1.6.0
• Fix Version/s: 1.6.0
• Labels: libprocess logging socket

Environment

https://reviews.apache.org/r/65474/

• Target Version/s: 1.6.0
• Sprint: Mesosphere Sprint 73, Mesosphere Sprint 74
• Story Points: 3
• Assignee: Till Toenshoff
• Reporter: Till Toenshoff
• Shepherd: Benjamin Mahler
• Created: 31/Jan/18 00:51
• Updated: 21/Oct/18 23:38
• Resolved: 06/Feb/18 00:31

Description

When within libprocess a socket is closing, we try to shut it down. That shutdown fails as the socket is not connected. This is intended behavior. The error code returned ENOTCONN tells us that there is nothing to see here for such common scenario.

The problem appears to be the logging of such event - that might appear as not useful - no matter which log-level is used.

E1214 08:15:18.017247 20752 process.cpp:2401] Failed to shutdown socket with fd 288: Transport endpoint is not connected

We should try to prevent this specific, non actionable logging entirely while making sure we do not hinder debugging scenarios.