[MESOS-8465] Resource usage calculation in docker containerizer can race with container destruction

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Not A Bug
• Affects Version/s: 1.5.0
• Component/s: containerization, docker
• Assignee: Unassigned
• Reporter: Benjamin Bannier
• Created: 19/Jan/18 14:05
• Updated: 24/Jan/18 13:54
• Resolved: 24/Jan/18 13:54

Description

The implementation of DockerContainerizerProcess::usage checks on the top-level whether the container is in DESTROYING state and returns a failure in that case. It then possibly triggers compuation of the container pid, and defers calculating the usage on that pid. The defered calculation only makes sure that the container is not already destroyed.

If a user first requests the usage and then triggers container destruction, usage could find the container not in DESTROYING state and would then defer the usage computation. If the destroy is processed it would trigger the actual killing of the container and mark the container as DESTROYING. If the container is not fully destroyed the deferred usage calculation could then pick up results not corresponding to the container anymore.