Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-8447

Incomplete output of apply-reviews.py --dry-run

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.6.0
    • build
    • None
    • 1

    Description

      The script support/apply-reviews.py has a flag --dry-run which should dump the commands which would be performed. This flag is useful to e.g., reorder patch chains or to manually resolve intermediate conflicts while still being able to pull a full chain.

      The output looks like this

      % ./support/apply-reviews.py -r 62447 -c -n -3 --dry-run
      wget --no-check-certificate --no-verbose -O 62160.patch https://reviews.apache.org/r/62160/diff/raw/
      git apply --index 62160.patch --3way
      git commit --author "Benno Evers <bevers@mesosphere.com>" -aF "62160.message"
      wget --no-check-certificate --no-verbose -O 62161.patch https://reviews.apache.org/r/62161/diff/raw/
      git apply --index 62161.patch --3way
      git commit --author "Benno Evers <bevers@mesosphere.com>" -aF "62161.message"
      wget --no-check-certificate --no-verbose -O 62444.patch https://reviews.apache.org/r/62444/diff/raw/
      git apply --index 62444.patch --3way
      git commit --author "Benno Evers <bevers@mesosphere.com>" -aF "62444.message"
      wget --no-check-certificate --no-verbose -O 62445.patch https://reviews.apache.org/r/62445/diff/raw/
      git apply --index 62445.patch --3way
      git commit --author "Benno Evers <bevers@mesosphere.com>" -aF "62445.message"
      wget --no-check-certificate --no-verbose -O 62447.patch https://reviews.apache.org/r/62447/diff/raw/
      git apply --index 62447.patch --3way
      git commit --author "Benno Evers <bevers@mesosphere.com>" -aF "62447.message"

      Trying to replay that dry run leads to an error since the commands to create the commit message files are not printed.

      We should add these commands to the output.

      Attachments

        Activity

          People

            bbannier Benjamin Bannier
            bbannier Benjamin Bannier
            Till Toenshoff Till Toenshoff
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: