Mesos
  1. Mesos
  2. MESOS-83

Filters should be removed when more resources are available than rejected offer had

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.0
    • Fix Version/s: 0.10.0
    • Component/s: master
    • Labels:

      Description

      Currently, if a framework rejects an offer and sets a filter for a slave, then more resources become available (such as by a task finishing), the framework will not get another offer until its filter expires. Instead, the filter should be removed whenever more resources (than at least the size of the rejected offer) become available on the slave.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2898/
        -----------------------------------------------------------

        Review request for mesos.

        Summary
        -------

        Note: this is a patch against the MESOS-46 patch to simplify the added test, so either that needs to be committed first or the test needs to be changed substantially.

        This test makes filters installed by rejecting an offer track the amount of resources rejected. The filter will only discard offers for the filtered slave when the offer would be no larger than the rejected offer.

        This addresses bug MESOS-83.
        https://issues.apache.org/jira/browse/MESOS-83

        Diffs


        src/master/master.hpp fdacf36
        src/master/master.cpp b6cfde7
        src/tests/master_tests.cpp 2438114
        src/tests/utils.hpp 02772f7

        Diff: https://reviews.apache.org/r/2898/diff

        Testing
        -------

        Thanks,

        Charles

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2898/ ----------------------------------------------------------- Review request for mesos. Summary ------- Note: this is a patch against the MESOS-46 patch to simplify the added test, so either that needs to be committed first or the test needs to be changed substantially. This test makes filters installed by rejecting an offer track the amount of resources rejected. The filter will only discard offers for the filtered slave when the offer would be no larger than the rejected offer. This addresses bug MESOS-83 . https://issues.apache.org/jira/browse/MESOS-83 Diffs src/master/master.hpp fdacf36 src/master/master.cpp b6cfde7 src/tests/master_tests.cpp 2438114 src/tests/utils.hpp 02772f7 Diff: https://reviews.apache.org/r/2898/diff Testing ------- Thanks, Charles
        Hide
        Charles Reiss added a comment -

        I believe this has been fixed incidentally as a result of the allocator refactoring.

        Show
        Charles Reiss added a comment - I believe this has been fixed incidentally as a result of the allocator refactoring.

          People

          • Assignee:
            Charles Reiss
            Reporter:
            Charles Reiss
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development