[MESOS-8277] Use of GCC extension broke Windows build

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed

Environment

Windows

• Assignee: Akash Gupta
• Reporter: Andrew Schwartzmeyer
• Shepherd: Andrew Schwartzmeyer
• Created: 29/Nov/17 22:55
• Updated: 30/Nov/17 00:25
• Resolved: 30/Nov/17 00:25

Description

Commit https://github.com/apache/mesos/commit/17d186e379d2db3edb04743a061dc05e24c32c9b broke the Windows build:

src\mesos\src\master\constants.cpp(25): error C2466: cannot allocate an array of constant size 0

The code:

MasterInfo::Capability::Type types[] = {}; // Empty for now.

Is not valid C++ code, it is instead a GCC extension (and so is not available with MSVC, and possibly also not available with Clang).

This is a blocking bug because the build is broken.