Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-8217

Don't run linters on every commit

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.5.0
    • None
    • None

    Description

      The mesos `pre-commit` hook is currently running several linters on the source code, some of which are even dynamically installed from the internet during a commit.

      This can hinder development because it also applies to local commits that are not intended to be ever published, and can quickly become annoying when rebasing old branches.

      Instead, we should think about putting these hooks into a separate `support/verify-reviews.py` which would be executed when trying to post a review, since at this point the patches should be cleaned up and pass all linter checks.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ArmandGrillet Armand Grillet
            bennoe Benno Evers
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment