[MESOS-8155] subprocess clone argument should return a Try<pid_t>

• Type: Bug
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Component/s: libprocess
• Assignee: James Peach
• Reporter: James Peach
• Created: 01/Nov/17 16:02
• Updated: 01/Nov/17 17:44

Description

In libprocess, the subprocess API accepts a clone argument. This is supposed to return a pid_t and set errno on error. However. Mesos sometimes passes ns::clone as the clone argument, and this API does not set errno which results in subprocess propagating a misleading error message up the stack.

Since it is not at all obvious how to map all the ns::clone error conditions to an expressive errno, we should just change the clone argument to return a Try<pid_t>.

Issue Links

• relates to: MESOS-8142 Improve container security with user namespaces.