[MESOS-8093] Some tests miss subscribed event because expectation is set after event fires.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Component/s: scheduler driver, test
• Labels: flaky-test mesosphere
• Sprint: Mesosphere Sprint 67
• Story Points: 2
• Assignee: Armand Grillet
• Reporter: Alex R
• Shepherd: Alex R
• Created: 14/Oct/17 06:02
• Updated: 09/Nov/17 19:23
• Resolved: 07/Nov/17 13:58

Description

Tests

CgroupsIsolatorTest.ROOT_CGROUPS_LimitSwap
DefaultExecutorCniTest.ROOT_VerifyContainerIP
DockerRuntimeIsolatorTest.ROOT_INTERNET_CURL_NestedSimpleCommand
DockerRuntimeIsolatorTest.ROOT_NestedDockerDefaultCmdLocalPuller
DockerRuntimeIsolatorTest.ROOT_NestedDockerDefaultEntryptLocalPuller

all have the same problem. They initiate a scheduler subscribe call in reaction to connected event. However, an expectation for subscribed event is created afterwards, which might lead to an uninteresting mock function call for subscribed followed by a failure to wait for subscribed, see attached log excerpt for more details. Problematic code is here: https://github.com/apache/mesos/blob/1c51c98638bb9ea0e8ec6a3f284b33d6c1a4e8ef/src/tests/containerizer/runtime_isolator_tests.cpp#L593-L615

A possible solution is to await for subscribed only, without connected, setting the expectation before a connection is attempted, see https://github.com/apache/mesos/blob/1c51c98638bb9ea0e8ec6a3f284b33d6c1a4e8ef/src/tests/default_executor_tests.cpp#L139-L159.

Issue Links

• duplicates: MESOS-8000 DefaultExecutorCniTest.ROOT_VerifyContainerIP is flaky.