[MESOS-7975] The command/default/docker executor can incorrectly send a TASK_FINISHED update even when the task is killed

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.2.3, 1.3.2, 1.4.2, 1.5.0
• Labels: mesosphere
• Target Version/s: 1.5.0
• Sprint: Mesosphere Sprint 65, Mesosphere Sprint 66, Mesosphere Sprint 67
• Story Points: 3
• Assignee: Qian Zhang
• Reporter: Anand Mazumdar
• Shepherd: Vinod Kone
• Created: 13/Sep/17 22:01
• Updated: 27/Nov/17 07:45
• Resolved: 01/Nov/17 11:58

Description

Currently, when a task is killed, the default/command/docker executor incorrectly send a TASK_FINISHED status update instead of TASK_KILLED. This is due to an unfortunate missed conditional check when the task exits with a zero status code.

      if (WSUCCEEDED(status)) {
        taskState = TASK_FINISHED;
      } else if (killed) {
        // Send TASK_KILLED if the task was killed as a result of
        // kill() or shutdown().
        taskState = TASK_KILLED;
      } else {
        taskState = TASK_FAILED;
      }

We should modify the code to correctly send TASK_KILLED status updates when a task is killed.