[MESOS-7926] Abnormal termination of default executor can cause MesosContainerizer::destroy to fail.

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.2.2, 1.3.1, 1.4.0
• Fix Version/s: 1.2.3, 1.3.2, 1.4.0
• Assignee: Jie Yu
• Reporter: Jie Yu
• Created: 30/Aug/17 04:08
• Updated: 05/Sep/17 07:29
• Resolved: 01/Sep/17 02:59

Description

This is the sequence of events:
1) Default executor launches a nested container
2) Default executor invokes agent API WAIT_NESTED_CONTAINER
3) Default executor is killed
4) The connection to the agent for WAIT_NESTED_CONTAINER breaks
5) libprocess discard the future, which propagates to the code here.
6) `termination.future()` has the discard flag being set to true (i.e., hasDiscard() == true).
7) Default executor termination triggers container destroy for the nested container
8) When the destroy of the nested container is done, the control will reach here.
9) In the thenf handler for 'termination.future()', since `termination.future()` has discard flag set (hasDiscard() == true), we'll call promise->discard(), which cause the returned future to be in DISCARDED state.
10) The top level container destroy will fail because nested container destroy failed
11) This cause all isolator cleanup for the top level container not being called (e.g., CNI detach).