[MESOS-7791] subprocess' childMain using ABORT when encountering user errors

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.0
• Fix Version/s: 1.5.0
• Component/s: libprocess
• Labels: mesosphere tech-debt
• Sprint: Mesosphere Sprint 61, Mesosphere Sprint 62, Mesosphere Sprint 63
• Story Points: 5
• Assignee: Andrei Budnik
• Reporter: Benjamin Bannier
• Shepherd: James Peach
• Created: 13/Jul/17 09:43
• Updated: 07/Sep/17 05:31
• Resolved: 07/Sep/17 05:31

Description

In process/posix/subprocess.hpp's childMain we exit with ABORT when there was a user error,

ABORT: (/pkg/src/mesos/3rdparty/libprocess/include/process/posix/subprocess.hpp:195): Failed to os::execvpe on path '/SOME/PATH': Argument list too long

We here abort instead of simply _exit'ing and letting the user know that we couldn't deal with the given arguments.

Abort can potentially dump core, and since this abort is before the execvpe, the process image can potentially be large (e.g., >300 MB) which could quickly fill up a lot of disk space.

Issue Links

• relates to: MESOS-7160 Parsing of perf version segfaults