Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-7740

Powershell doesn't catch CRC errors when unzipping a file (fetcher)

Attach filesAttach ScreenshotVotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 1.7.0
    • None

    Description

      On Windows, Powershell is used to decompress zip files within the fetcher.

      In fetcher_tests.cpp, test FetcherTest.Unzip_ExtractInvalidFile, specifically tests for a .zip file with a bad CRC.

      On Linux, this is properly decoded, but considered an error since the 'unzip' utility returns 2.

      On Windows, this is properly decoded and a success code is returned.

      When we move to programmatically decoding container files (tar, gzip, zip, etc), then this issue should be resolved. The test is marked with TODO(jeffaco) for these changes.

      Attachments

        Issue Links

        is blocked by

        Improvement - An improvement or enhancement to an existing feature or task. MESOS-8064 Add capability so mesos can programmatically decode .zip, .tar, .gzip, and other common file compression schemes

        • Major - Major loss of function.
        • Resolved

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            johnkord John Kordich
            coffler Jeff Coffler
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment