[MESOS-7489] Reduce code duplication when requesting an ObjectApprover

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: agent, master, security
• Labels: code-cleanup mesosphere tech-debt
• Epic Link: Authorization Improvements
• Assignee: Unassigned
• Reporter: Alexander Rojas
• Created: 10/May/17 12:24
• Updated: 29/Apr/19 09:27

Description

Every time the code needs to use an authorizer, the following snippet is used:

Future<Owned<ObjectApprover>> somethingApprover;

if (master->authorizer.isSome()) {
  Option<authorization::Subject> subject = createSubject(principal);

  somethingApprover = master->authorizer.get()->getObjectApprover(
      subject, authorization::VIEW_FRAMEWORK);
} else {
  somethingApprover = Owned<ObjectApprover>(new AcceptingObjectApprover());
}

return somethingApprover.then(…)

This can be easily replace my a method:

Future<ObjectApprover> Master::approver(
  const Option<authorization::Subject> &subject,
  const authorization::Action &action)