[MESOS-7478] Pre-1.2.x master does not work with 1.2.x agent.

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.2.1, 1.3.0
• Component/s: agent
• Target Version/s: 1.2.1, 1.3.0
• Assignee: Benjamin Mahler
• Reporter: Benjamin Mahler
• Shepherd: Michael Park
• Created: 09/May/17 01:04
• Updated: 09/May/17 21:20
• Resolved: 09/May/17 21:20

Description

evilezh reported the following crash in the agent upon running a 1.1.0 master against a 1.2.0 agent:

F0509 00:19:07.045413  3469 slave.cpp:4609] Check failed: resource.has_allocation_info() 
*** Check failure stack trace: ***
    @     0x7f4c4a4fa3cd  google::LogMessage::Fail()
    @     0x7f4c4a4fc180  google::LogMessage::SendToLog()
    @     0x7f4c4a4f9fb3  google::LogMessage::Flush()
    @     0x7f4c4a4fcba9  google::LogMessageFatal::~LogMessageFatal()
    @     0x7f4c49b3bcf5  mesos::internal::slave::Slave::getExecutorInfo()
    @     0x7f4c49b3cf76  mesos::internal::slave::Slave::runTask()
    @     0x7f4c49b8832c  ProtobufProcess<>::handler4<>()
    @     0x7f4c49b4dc06  std::_Function_handler<>::_M_invoke()
    @     0x7f4c49b6975a  ProtobufProcess<>::visit()
    @     0x7f4c4a46c933  process::ProcessManager::resume()
    @     0x7f4c4a477537  _ZNSt6thread5_ImplISt12_Bind_simpleIFZN7process14ProcessManager12init_threadsEvEUt_vEEE6_M_runEv
    @     0x7f4c486b8c80  (unknown)
    @     0x7f4c481d46ba  start_thread
    @     0x7f4c47f0a82d  (unknown)
Aborted (core dumped)

This appears to have been due to a lack of manual upgrade testing (we also don't have any automated upgrade testing in place).

The check in getExecutorInfo(...) here crashes with an old master because it occurs before our injection in run(...). See the runTask(...) call into getExecutorInfo(...) here.