[MESOS-7346] Agent crashes if the task name is too long

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.0.0, 1.0.1, 1.0.2, 1.1.0, 1.1.1, 1.2.0
• Fix Version/s: 1.2.1, 1.3.0
• Component/s: agent
• Target Version/s: 1.2.1, 1.3.0
• Assignee: Aaron Wood
• Reporter: Aaron Wood
• Shepherd: Jie Yu
• Created: 04/Apr/17 23:10
• Updated: 19/Apr/17 23:35
• Resolved: 19/Apr/17 23:23

Description

While making a load testing tool that wrongly generated very long task names I found that the agent crashes:

I0404 18:59:26.716114  5145 slave.cpp:1701] Launching task 'test application43109915684310991568431099156843109915684310991568431099156843109915694310991569431099156943109915694310991569431099156943109915704310991570431099157043109915704310991570431099157143109915704310991571431099157143109915714310991572431099157243109915714310991571-6023D486-022C-40AC-BC24-42D07EFA8CB8' for framework 85ed4b54-b2f5-4513-9179-b18de7120f9b-0003
F0404 18:59:26.716377  5145 paths.cpp:508] CHECK_SOME(mkdir): File name too long Failed to create executor directory '/tmp/slave/slaves/85ed4b54-b2f5-4513-9179-b18de7120f9b-S0/frameworks/85ed4b54-b2f5-4513-9179-b18de7120f9b-0003/executors/test application43109915684310991568431099156843109915684310991568431099156843109915694310991569431099156943109915694310991569431099156943109915704310991570431099157043109915704310991570431099157143109915704310991571431099157143109915714310991572431099157243109915714310991571-6023D486-022C-40AC-BC24-42D07EFA8CB8/runs/f913fd46-b0a5-439a-a674-8e4a19aa9df3'
*** Check failure stack trace: ***
    @     0x7f247f2f7a46  google::LogMessage::Fail()
    @     0x7f247f2f798a  google::LogMessage::SendToLog()
    @     0x7f247f2f735c  google::LogMessage::Flush()
    @     0x7f247f2fa61a  google::LogMessageFatal::~LogMessageFatal()
    @           0x480c42  _CheckFatal::~_CheckFatal()
    @     0x7f247e5046a8  mesos::internal::slave::paths::createExecutorDirectory()
    @     0x7f247e540cf9  mesos::internal::slave::Framework::launchExecutor()
    @     0x7f247e51c337  mesos::internal::slave::Slave::_run()
    @     0x7f247e577af6  _ZZN7process8dispatchIN5mesos8internal5slave5SlaveERKNS_6FutureIbEERKNS1_13FrameworkInfoERKNS1_12ExecutorInfoERK6OptionINS1_8TaskInfoEERKSF_INS1_13TaskGroupInfoEES6_S9_SC_SH_SL_EEvRKNS_3PIDIT_EEMSP_FvT0_T1_T2_T3_T4_ET5_T6_T7_T8_T9_ENKUlPNS_11ProcessBaseEE_clES16_
    @     0x7f247e5af990  _ZNSt17_Function_handlerIFvPN7process11ProcessBaseEEZNS0_8dispatchIN5mesos8internal5slave5SlaveERKNS0_6FutureIbEERKNS5_13FrameworkInfoERKNS5_12ExecutorInfoERK6OptionINS5_8TaskInfoEERKSJ_INS5_13TaskGroupInfoEESA_SD_SG_SL_SP_EEvRKNS0_3PIDIT_EEMST_FvT0_T1_T2_T3_T4_ET5_T6_T7_T8_T9_EUlS2_E_E9_M_invokeERKSt9_Any_dataOS2_
    @     0x7f247f284187  std::function<>::operator()()
    @     0x7f247f26503e  process::ProcessBase::visit()
    @     0x7f247f26dad0  process::DispatchEvent::visit()
    @     0x7f247dcbea08  process::ProcessBase::serve()
    @     0x7f247f260efa  process::ProcessManager::resume()
    @     0x7f247f25da22  _ZZN7process14ProcessManager12init_threadsEvENKUt_clEv
    @     0x7f247f26d0f2  _ZNSt12_Bind_simpleIFZN7process14ProcessManager12init_threadsEvEUt_vEE9_M_invokeIJEEEvSt12_Index_tupleIJXspT_EEE
    @     0x7f247f26d048  _ZNSt12_Bind_simpleIFZN7process14ProcessManager12init_threadsEvEUt_vEEclEv
    @     0x7f247f26cfd8  _ZNSt6thread5_ImplISt12_Bind_simpleIFZN7process14ProcessManager12init_threadsEvEUt_vEEE6_M_runEv
    @     0x7f2479711c80  (unknown)
    @     0x7f247922d6ba  start_thread
    @     0x7f2478f6382d  (unknown)
Aborted (core dumped)

https://reviews.apache.org/r/58317/