Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-7168

Agent should validate that the nested container ID does not exceed certain length.

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.1.0, 1.2.0
    • 1.7.0
    • containerization

    Description

      This is related to MESOS-691.

      Since nested container ID is generated by the executor, the agent should verify that the length of it does not exceed certain length.

      Attachments

        Issue Links

          Activity

            xiaowei-cuc xiaowei added a comment - - edited

            the generated id is uuid, include dash, total 36.  Normal we can set the limit to 255, did we should consider windows os? gilbert  If not only windows 10, the file path will be limit to 260.  In Windows 10, the whole path limits to 32767  And I think it does not need to be reconfigured by mesos administrator.

            xiaowei-cuc xiaowei added a comment - - edited the generated id is uuid, include dash, total 36.  Normal we can set the limit to 255, did we should consider windows os? gilbert   If not only windows 10, the file path will be limit to 260.  In Windows 10, the whole path limits to 32767   And I think it does not need to be reconfigured by mesos administrator.

            I fixed long path issues on Windows. That is, all Windows APIs used by Mesos use the introduced long path support automatically (that is, we use the Unicode versions of the APIs and prepend the long path marker \\?\ when calling these APIs), so you should be good to go for Windows, and thanks for checking

            Also note that on Linux, 255 is too long. If you're running in docker, you'll often be on AUFS, and it has a per-path-component limit of 242 (see http://aufs.sourceforge.net/aufs3/man.html).

            andschwa Andrew Schwartzmeyer added a comment - I fixed long path issues on Windows. That is, all Windows APIs used by Mesos use the introduced long path support automatically (that is, we use the Unicode versions of the APIs and prepend the long path marker \\?\ when calling these APIs), so you should be good to go for Windows, and thanks for checking Also note that on Linux, 255 is too long. If you're running in docker, you'll often be on AUFS, and it has a per-path-component limit of 242 (see http://aufs.sourceforge.net/aufs3/man.html ).
            gilbert Gilbert Song added a comment -

            commit c545bbfa584d303956f3d8b4075680d3d4c9995e
            Author: wei xiao <xw927@outlook.com>
            Date: Thu Jun 21 11:58:14 2018 -0700

            Added a length validation for container IDs.

            Review: https://reviews.apache.org/r/67616/

            gilbert Gilbert Song added a comment - commit c545bbfa584d303956f3d8b4075680d3d4c9995e Author: wei xiao <xw927@outlook.com> Date: Thu Jun 21 11:58:14 2018 -0700 Added a length validation for container IDs. Review: https://reviews.apache.org/r/67616/

            People

              xiaowei-cuc xiaowei
              jieyu Jie Yu
              Gilbert Song Gilbert Song
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: