[MESOS-6895] Loop uses dependent nested names for friend declaration which isn't supported by recent clang

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.0
• Fix Version/s: 1.2.0
• Component/s: libprocess
• Labels: mesosphere
• Target Version/s: 1.2.0
• Sprint: Mesosphere Sprint 49
• Assignee: Jan Schlicht
• Reporter: Benjamin Bannier
• Created: 09/Jan/17 09:35
• Updated: 09/Jan/17 23:46
• Resolved: 09/Jan/17 23:46

Description

https://reviews.apache.org/r/54358/ (bbb4058d60) introduced ControlFlow for process::loop. Here a dependent nested name specifier is used in a friend declaration which is not supported by recent clang.

In file included from ../../../3rdparty/libprocess/src/tests/loop_tests.cpp:20:
/private/tmp/mesos.master/3rdparty/libprocess/include/process/loop.hpp|214 col 32| warning: dependent nested name specifier 'ControlFlow<U>::' for friend class declaration is not supported; turning off access control for 'ControlFlow' [-Wunsupported-friend]
  friend class ControlFlow<U>::Continue;
               ~~~~~~~~~~~~~~~~^
/private/tmp/mesos.master/3rdparty/libprocess/include/process/loop.hpp|216 col 32| warning: dependent nested name specifier 'ControlFlow<U>::' for friend class declaration is not supported; turning off access control for 'ControlFlow' [-Wunsupported-friend]
  friend class ControlFlow<U>::Break;
               ~~~~~~~~~~~~~~~~^