[MESOS-6862] Replace os::system usages to reduce the risk of command injection.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Assignee: James Peach
• Reporter: James Peach
• Shepherd: Yan Xu
• Created: 05/Jan/17 17:55
• Updated: 31/Jan/17 18:35
• Resolved: 18/Jan/17 02:08

Description

There are a number of places where os::system is used for convenience. To reduce the risk of command injection, we should replace most of these with subprocess or os::spawn and not execute them with the shell.

posix/chown.hpp	os::chown	Replace with fts(3).
launcher/fetcher.cpp	extract()	Replace with subprocess.
launcher/fetcher.cpp	copyFile	Replace with subprocess.
linux/perf.cpp	valid()	Replace with subprocess.
cni/cni.cpp	NetworkCniIsolatorSetup::execute()	Not a problem, but should use subprocess for consistency.
port_mapper/port_mapper.cpp	PortMapper::addPortMapping()	Replace with subprocess.
port_mapper/port_mapper.cpp	PortMapper::delPortMapping()	Replace with subprocess.

In the above table, read "replacement" as replacement with os::spawn or subprocess as appropriate.

Issue Links

• relates to: MESOS-7041 Default CommandInfo usage to not use the shell.
• relates to: MESOS-6866 Mesos agent not checking IDs before using them as part of the paths