[MESOS-6824] mesos-this-capture clang-tidy check has false positives

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Labels: clang-tidy
• Target Version/s: 1.2.0
• Epic Link: clang-tidy
• Sprint: Mesosphere Sprint 49
• Story Points: 2
• Assignee: Benjamin Bannier
• Reporter: Benjamin Bannier
• Shepherd: Michael Park
• Created: 21/Dec/16 15:56
• Updated: 26/Mar/18 08:04
• Resolved: 11/Jan/17 03:15

Description

The mesos-this-capture clang-tidy checks incorrectly triggers on the code here,

https://github.com/apache/mesos/blob/d2117362349ab4c383045720f77d42b2d9fd6871/src/slave/containerizer/mesos/io/switchboard.cpp#L1487

We should tighten the matcher to avoid triggering on such constructs.