[MESOS-6665] io::redirect might cause stack overflow.

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Labels: mesosphere
• Target Version/s: 1.2.0
• Epic Link: Mesos Container Attach/Exec
• Sprint: Mesosphere Sprint 48
• Assignee: Benjamin Hindman
• Reporter: Jie Yu
• Shepherd: Jie Yu
• Created: 01/Dec/16 20:31
• Updated: 06/Feb/17 19:22
• Resolved: 31/Jan/17 17:16

Description

Can reproduce this on macOS sierra:

[----------] 6 tests from IOTest
[ RUN      ] IOTest.Poll
[       OK ] IOTest.Poll (0 ms)
[ RUN      ] IOTest.Read
[       OK ] IOTest.Read (3 ms)
[ RUN      ] IOTest.BufferedRead
[       OK ] IOTest.BufferedRead (5 ms)
[ RUN      ] IOTest.Write
[       OK ] IOTest.Write (1 ms)
[ RUN      ] IOTest.Redirect
make[6]: *** [check-local] Illegal instruction: 4
make[5]: *** [check-am] Error 2
make[4]: *** [check-recursive] Error 1
make[3]: *** [check] Error 2
make[2]: *** [check-recursive] Error 1
make[1]: *** [check] Error 2
make: *** [check-recursive] Error 1
(reverse-i-search)`k': make check -j3
Jies-MacBook-Pro:build jie$ lldb 3rdparty/libprocess/libprocess-tests
(lldb) target create "3rdparty/libprocess/libprocess-tests"
Current executable set to '3rdparty/libprocess/libprocess-tests' (x86_64).
(lldb) run --gtest_filter=IOTest.Redirect
Process 26064 launched: '/Users/jie/workspace/dist/mesos/build/3rdparty/libprocess/libprocess-tests' (x86_64)
Note: Google Test filter = IOTest.Redirect
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from IOTest
[ RUN      ] IOTest.Redirect
Process 26064 stopped
* thread #2: tid = 0x152c5c, 0x00007fffd6d463e0 libsystem_malloc.dylib`szone_malloc_should_clear + 78, stop reason = EXC_BAD_ACCESS (code=2, address=0x70000eb16ff8)
    frame #0: 0x00007fffd6d463e0 libsystem_malloc.dylib`szone_malloc_should_clear + 78
libsystem_malloc.dylib`szone_malloc_should_clear:
->  0x7fffd6d463e0 <+78>: movq   %rax, -0x78(%rbp)
    0x7fffd6d463e4 <+82>: movq   0x10f0(%r12), %r13
    0x7fffd6d463ec <+90>: leaq   (%rax,%rax,4), %r14
    0x7fffd6d463f0 <+94>: shlq   $0x9, %r14
(lldb) bt
.....
frame #2794: 0x00007fffd6ddb221 libsystem_pthread.dylib`thread_start + 13

Change the test to redirect just 1KB data will hide the issue.

Issue Links

• relates to: MESOS-6813 IOSwitchboardServerTest.AttachOutput has stack overflow issue.
• relates to: MESOS-6913 AgentAPIStreamingTest.AttachInputToNestedContainerSession fails on Mac OS.