[MESOS-6632] ContainerLogger might leak FD if container launch fails.

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Duplicate
• Affects Version/s: 0.28.2, 1.0.1, 1.1.0
• Component/s: containerization
• Assignee: Andrei Budnik
• Reporter: Jie Yu
• Created: 23/Nov/16 19:14
• Updated: 08/Feb/19 16:12
• Resolved: 09/Jan/19 19:16

Description

In MesosContainerizer, if logger->prepare() succeeds but its continuation fails, the pipe fd allocated in the logger will get leaked. We cannot add a destructor in ContainerLogger::SubprocessInfo to close the fd because subprocess might close the OWNED fd.

A FD abstraction might help here. In other words, subprocess will no longer be responsible for closing external FDs, instead, the FD destructor will be doing so.

Issue Links

• is duplicated by: MESOS-9502 IOswitchboard cleanup could get stuck due to FD leak from a race.