Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-6425

Release scripts fail due to missing BLINK capability.

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      Our release-scripts support/tag.sh & support/vote.sh both fail entirely due to their way of initializing the terminal.
      Specifically the included support/colors.sh script's line:

       BLINK=$(tput blink)
      

      When changing the initializing to allow for better debugging set -e -x the resulting trace makes the problem apparent:

      $ ./support/tag.sh 1.1.0 2
      ++ dirname ./support/tag.sh
      + . ./support/atexit.sh
      ++ declare -a __atexit_cmds
      ++ dirname ./support/tag.sh
      + . ./support/colors.sh
      ++ test -t 1
      +++ tput colors
      ++ NUM_COLORS=8
      ++ test -n 8
      ++ test 8 -ge 8
      +++ tput sgr0
      ++ NORMAL=''
      +++ tput bold
      ++ BOLD=''
      +++ tput smul
      ++ UNDERLINE=''
      +++ tput smso
      ++ REVERSE=''
      +++ tput blink
      ++ BLINK=
      

      My terminal (iTerm2 with xterm-color256) apparently does not support blinking this way.

      $ tput blink
      $ echo $?
      1
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            tillt Till Toenshoff
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: