Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-6283

Fix the Web UI allowing access to the task sandbox for nested containers.

Details

    • Bug
    • Status: Resolved
    • Blocker
    • Resolution: Fixed
    • None
    • 1.1.0
    • webui

    Description

      Currently, the sandbox button for a child task is broken on the WebUI. It does nothing and dies with an error that the executor for this task cannot be found. We need to fix the WebUI to follow the symlink "tasks/taskId" and display the task sandbox to the users.

      Attachments

        1. sandbox.gif
          970 kB
          haosdent

        Activity

          haosdent@gmail.com haosdent added a comment - - edited
          Filled missing executor info in tasks when `LAUNCH_GROUP`. https://reviews.apache.org/r/52470/
          Exposed the executor's type in the endpoints. https://reviews.apache.org/r/52520/
          Fixed the wrong sandbox directory of the tasks in Web UI. https://reviews.apache.org/r/52471
          haosdent@gmail.com haosdent added a comment - - edited Filled missing executor info in tasks when `LAUNCH_GROUP`. https://reviews.apache.org/r/52470/ Exposed the executor's type in the endpoints. https://reviews.apache.org/r/52520/ Fixed the wrong sandbox directory of the tasks in Web UI. https://reviews.apache.org/r/52471
          vinodkone Vinod Kone added a comment -

          Can you transition this to "Reviewable"?

          vinodkone Vinod Kone added a comment - Can you transition this to "Reviewable"?
          alexr Alex R added a comment -

          Folks, do you still plan to land it in 1.1.0?

          alexr Alex R added a comment - Folks, do you still plan to land it in 1.1.0?
          haosdent@gmail.com haosdent added a comment -

          I think this is a blocker, let me ping vinodkone today again.

          haosdent@gmail.com haosdent added a comment - I think this is a blocker, let me ping vinodkone today again.
          vinodkone Vinod Kone added a comment -

          commit 9afaaffd8badbe4e28013e25918cd62afe1e0edd
          Author: haosdent huang <haosdent@gmail.com>
          Date: Fri Oct 14 11:59:48 2016 -0700

          Moved the `decimalFloat` filter to app.js for consistency.

          Review: https://reviews.apache.org/r/52664/

          commit 6762fc8fb26470e3e24a915d4c19ceb2005fcce7
          Author: haosdent huang <haosdent@gmail.com>
          Date: Fri Oct 14 11:59:44 2016 -0700

          Fixed the wrong sandbox directory of the tasks in Web UI.

          For the task launched by default-executor, its sandbox directory is
          'executor_directory/tasks/task_id/'. This patch generates the
          corresponding sandbox directory in Web UI for the task according to its
          executor type.

          Review: https://reviews.apache.org/r/52471/

          commit 88cd1df7af6904e2a34ece1f10bee59915d68f67
          Author: haosdent huang <haosdent@gmail.com>
          Date: Fri Oct 14 11:59:39 2016 -0700

          Exposed the executor's type in the endpoints.

          Review: https://reviews.apache.org/r/52520/

          commit d2da824cfbfc4242ea4962d763da9726faf7aaca
          Author: haosdent huang <haosdent@gmail.com>
          Date: Fri Oct 14 11:59:32 2016 -0700

          Filled missing executor info in tasks when `LAUNCH_GROUP`.

          This fixed the navigate error in Web UI because Web UI uses the
          executor id of the task to search the corresponding sandbox directory.
          Web UI uses the task id as the executor id if the executor id of the
          task is empty when searching the sandbox directory. It works fine when
          tasks are launched by `CommandExecutor` because the executor id of the
          task is equal to the task id in this case. However, when tasks are
          launched by `DefaultExecutor`, the executor id of the task is defined
          in the framework side and may different with the task id. So we need to
          fill the `ExecutorInfo` of the `TaskInfo` when `LAUNCH_GROUP` to avoid
          the Web UI uses incorrect executor id to search sandbox directory.

          Review: https://reviews.apache.org/r/52470/
          commit ebe7ea56fa0f00e63a3fd274eaad75b58985b075
          Author: haosdent huang <haosdent@gmail.com>
          Date: Fri Oct 14 11:59:26 2016 -0700

          Added utils method to check if `ExecutorInfo` different.

          Review: https://reviews.apache.org/r/52817/

          vinodkone Vinod Kone added a comment - commit 9afaaffd8badbe4e28013e25918cd62afe1e0edd Author: haosdent huang <haosdent@gmail.com> Date: Fri Oct 14 11:59:48 2016 -0700 Moved the `decimalFloat` filter to app.js for consistency. Review: https://reviews.apache.org/r/52664/ commit 6762fc8fb26470e3e24a915d4c19ceb2005fcce7 Author: haosdent huang <haosdent@gmail.com> Date: Fri Oct 14 11:59:44 2016 -0700 Fixed the wrong sandbox directory of the tasks in Web UI. For the task launched by default-executor, its sandbox directory is 'executor_directory/tasks/task_id/'. This patch generates the corresponding sandbox directory in Web UI for the task according to its executor type. Review: https://reviews.apache.org/r/52471/ commit 88cd1df7af6904e2a34ece1f10bee59915d68f67 Author: haosdent huang <haosdent@gmail.com> Date: Fri Oct 14 11:59:39 2016 -0700 Exposed the executor's type in the endpoints. Review: https://reviews.apache.org/r/52520/ commit d2da824cfbfc4242ea4962d763da9726faf7aaca Author: haosdent huang <haosdent@gmail.com> Date: Fri Oct 14 11:59:32 2016 -0700 Filled missing executor info in tasks when `LAUNCH_GROUP`. This fixed the navigate error in Web UI because Web UI uses the executor id of the task to search the corresponding sandbox directory. Web UI uses the task id as the executor id if the executor id of the task is empty when searching the sandbox directory. It works fine when tasks are launched by `CommandExecutor` because the executor id of the task is equal to the task id in this case. However, when tasks are launched by `DefaultExecutor`, the executor id of the task is defined in the framework side and may different with the task id. So we need to fill the `ExecutorInfo` of the `TaskInfo` when `LAUNCH_GROUP` to avoid the Web UI uses incorrect executor id to search sandbox directory. Review: https://reviews.apache.org/r/52470/ commit ebe7ea56fa0f00e63a3fd274eaad75b58985b075 Author: haosdent huang <haosdent@gmail.com> Date: Fri Oct 14 11:59:26 2016 -0700 Added utils method to check if `ExecutorInfo` different. Review: https://reviews.apache.org/r/52817/

          People

            haosdent@gmail.com haosdent
            anandmazumdar Anand Mazumdar
            Vinod Kone Vinod Kone
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: