Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-6115

Source tree contains compiled protobuf source

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.4.0
    • stout, test
    • Mesosphere Sprint 60
    • 3

    Description

      Stout's protobuf_tests.cpp uses checked in, generated protobuf files protobuf_tests.pb.h and protobuf_tests.pb.cc.

      These files are

      • not meant to be edited,
      • might require updates whenever protobuf is updated, and
      • likely do not follow Mesos coding standards.

      We should try to remove them from the source tree.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MESOS-4096 stout tests fail to build with external protobuf version

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. MESOS-3323 Auto-generate protos for stout tests

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Accepted

          Activity

            People

              qianzhang Qian Zhang
              bbannier Benjamin Bannier
              James Peach James Peach
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: