Details
-
Bug
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
Description
`fcntl.hpp` has a bunch of functions that will never work on Windows. We will need to work around them, either by working around specific call sites of functions like `os::cloexec`, or by implementing something that keeps track of which file descriptors are cloexec, and which aren't.
NOTE: We have elected to log warnings for these functions when we call them, so that it is obvious they have done nothing. This carries a performance penalty especially for the master, and when we resolve this issue, it is important we remove the logging as well.