[MESOS-5009] local docker puller fails to find private registry repositories

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.28.0
• Fix Version/s: 0.28.1
• Component/s: containerization, docker
• Labels: container containerizer mesosphere
• Epic Link: Unified Container
• Assignee: James Peach
• Reporter: James Peach
• Shepherd: Jie Yu
• Created: 22/Mar/16 21:38
• Updated: 26/Nov/18 12:20
• Resolved: 26/Nov/18 12:20

Description

If you use the unified containerizer and the local docker puller with a Docker image from a private registry, the local puller fails to find any layers in the image's repository manifest.

For example, the image's repository file looks like this:

$  cat repositories
{"docker-registry.foo.com/image":{"latest":"c6c35f224e926912cb61ddc48b36376c65806378432b9cbb895e10a17a99b49d"}}

There's 2 problems that prevent this working. First, the local puller needs to check reference.registry()/reference.repository() as well as reference.repository(). Second, in JSON::Object::find, the dot is treated specially so we need to just index the top level object keys.