[MESOS-4587] Docker environment variables must be able to contain the equal sign

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.25.0, 0.26.0, 0.27.0
• Fix Version/s: 0.28.0
• Component/s: docker
• Labels: containerizer
• Target Version/s: 0.27.1
• Assignee: Shuai Lin
• Reporter: Martin Tapp
• Shepherd: Jie Yu
• Created: 03/Feb/16 17:08
• Updated: 31/Mar/16 16:08
• Resolved: 05/Feb/16 17:24

Description

Note: Affects 0.26 and 0.27.

The Jupyter Docker all-spark-notebook uses equal sign ('=') in Docker ENV declarations (for instance, https://github.com/jupyter/docker-stacks/blob/master/all-spark-notebook/Dockerfile#L51).

This causes a mesos Unexpected Env format for 'ContainerConfig.Env' error.

The problem is the tokenization code at https://github.com/apache/mesos/blob/21e080c5ae6ef03556c7a2b588e034a916c7a05a/src/docker/docker.cpp#L386 which needs to only look at the first equal sign. Docker ENV declarations can also be empty.

Issue Links

• relates to: MESOS-4594 Parsing 'Env' in docker images renders private Docker registries unusable