[MESOS-3879] Incorrect and inconsistent include order for <gmock/gmock.h> and <gtest/gtest.h>.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Labels: mesosphere
• Target Version/s: 0.26.0
• Sprint: Mesosphere Sprint 22
• Story Points: 1
• Assignee: Jörg Schad
• Reporter: Jörg Schad
• Shepherd: Till Toenshoff
• Created: 10/Nov/15 18:28
• Updated: 26/Nov/18 12:22
• Resolved: 26/Nov/18 12:22

Description

We currently have an inconsistent (and mostly incorrect) include order for <gmock/gmock.h> and <gtest/gtest.h> (see below). Some files include them (incorrectly) between the c and cpp standard header, while other correclt include them afterwards. According to the Google Styleguide the second include order is correct.

external_containerizer_test.cpp

#include <unistd.h>

#include <gmock/gmock.h>

#include <string>

launcher.hpp

#include <vector>

#include <gmock/gmock.h>