[MESOS-3743] Provide diagnostic output in agent log when fetching fails

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.26.0
• Component/s: fetcher
• Labels: mesosphere
• Target Version/s: 0.26.0
• Sprint: Mesosphere Sprint 21
• Story Points: 2
• Assignee: Bernd Mathiske
• Reporter: Bernd Mathiske
• Shepherd: Till Toenshoff
• Created: 15/Oct/15 12:35
• Updated: 26/Nov/18 12:22
• Resolved: 26/Nov/18 12:22

Description

When fetching fails, the fetcher has written log output to stderr in the task sandbox, but it is not easy to get to. It may even be impossible to get to if one only has the agent log available and no more access to the sandbox. This is for instance the case when looking at output from a CI run.

The fetcher actor in the agent detects if the external fetcher program claims to have succeeded or not. When it exits with an error code, we could grab the fetcher log from the stderr file in the sandbox and append it to the agent log.

This is similar to this patch: https://reviews.apache.org/r/37813/

The difference is that the output of the latter is triggered by test failures outside the fetcher, whereas what is proposed here is triggering upon failures inside the fetcher.