[MESOS-3625] Add support for github and variable base URLs to apply-reviews.py

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Labels: mesosphere
• Story Points: 3
• Assignee: Artem Harutyunyan
• Reporter: Artem Harutyunyan
• Shepherd: Adam B
• Created: 08/Oct/15 20:50
• Updated: 26/Nov/18 12:22
• Resolved: 26/Nov/18 12:22

Description

From Adam's email on dev@ list:

I have used the '-g' feature for github PRs in the past, and we should
continue to support that model, so that new Mesos contributors don't have
to create new RB accounts and learn a new process just for quick
documentation changes, etc.

As a side note, now that the Myriad incubator project has migrated to
Apache git and we can no longer merge PRs directly, we were hoping to take
advantage of a tool like apply-reviews to apply our PR patches. It looks
like apply-reviews.sh only specifies 'mesos' in the GITHUB_URL/API_URL.
Would apply-reviews.py be just as easy to reuse for another project (i.e.
Myriad)?

Issue Links

• duplicates: MESOS-3859 Add github support to apply-reviews.py.
• is related to: MESOS-3468 Improve apply_reviews.sh script to apply chain of reviews