[MESOS-3518] Assertions that compare doubles with == can fail due to rounding issues and can crash the master.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 0.23.0, 0.23.1, 0.24.0, 0.24.1
• Component/s: master
• Epic Link: FloatPoint Operations
• Assignee: Unassigned
• Reporter: Max Neunhöffer
• Created: 25/Sep/15 14:25
• Updated: 26/Nov/15 02:00
• Resolved: 25/Nov/15 00:13

Description

mesos-0.23.0/src/common/resources.cpp has
CHECK(result.cpus() == cpus() &&
result.mem() == mem() &&
result.disk() == disk() &&
result.ports() == ports());
at around line 869. Sometimes, rounding errors can trigger this check to fail because of the cpus() part. One should take the absolute value of the difference and compare with a small value to avoid this problem. The same problem could be true in various places, so far I have not yet checked.
Seems to be present in all versions I checked. I could trigger this by asking for some resource value of cpus( *):0.2

Issue Links

• duplicates: MESOS-3552 CHECK failure due to floating point precision on reservation request