[MESOS-3339] Implement filtering mechanism for (Scheduler API Events) Testing

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.28.0
• Component/s: test
• Labels: mesosphere
• Epic Link: Scheduler API v1 improvements
• Sprint: Mesosphere Sprint 20, Mesosphere Sprint 21, Mesosphere Sprint 22, Mesosphere Sprint 29
• Story Points: 3
• Assignee: Anand Mazumdar
• Reporter: Anand Mazumdar
• Shepherd: Vinod Kone
• Created: 31/Aug/15 16:26
• Updated: 26/Nov/18 12:21
• Resolved: 26/Nov/18 12:21

Description

Currently, our testing infrastructure does not have a mechanism of filtering/dropping HTTP events of a particular type from the Scheduler API response stream. We need a DROP_HTTP_CALLS abstraction that can help us to filter a particular event type.

// Enqueues all received events into a libprocess queue.
ACTION_P(Enqueue, queue)
{
  std::queue<Event> events = arg0;
  while (!events.empty()) {
    // Note that we currently drop HEARTBEATs because most of these tests
    // are not designed to deal with heartbeats.
    // TODO(vinod): Implement DROP_HTTP_CALLS that can filter heartbeats.
    if (events.front().type() == Event::HEARTBEAT) {
      VLOG(1) << "Ignoring HEARTBEAT event";
    } else {
      queue->put(events.front());
    }
    events.pop();
  }
}

This helper code is duplicated in at least two places currently, Scheduler Library/Maintenance Primitives tests.

• The solution can be as trivial as moving this helper function to a common test-header.
• Implement a DROP_HTTP_CALLS similar to what we do for other protobufs via DROP_CALLS.

Issue Links

• blocks: MESOS-4029 ContentType/SchedulerTest is flaky.
• blocks: MESOS-3355 Testing the HTTP V1 API
• is related to: MESOS-3418 Factor out V1 API test helper functions
• is related to: MESOS-4433 Implement a callback testing interface for the Executor Library