Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-3329

Unused hashmap::existsValue functions have incomplete code paths

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • None
    • 0.26.0
    • stout

    Description

      `stout/hashmap.hpp` defines functions `hashmap::existsValue`. These return true if a certain value exists in the hashmap instance. The control flow of these functions doesn't cover the case that the value is not found, which should result in false. Right now the result in this case is undefined.
      As the `existsValue` functions are never called this doesn't result in a compile error atm.
      Possible solutions:
      1) Add `return false`
      2) Remove function

      Attachments

        Issue Links

          Activity

            People

              qiujian Jian Qiu
              nfnt Jan Schlicht
              Vinod Kone Vinod Kone
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: