[MESOS-3301] Should remove redundant check

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Not A Problem
• Assignee: James Wang
• Reporter: James Wang
• Created: 20/Aug/15 08:25
• Updated: 01/Sep/15 02:21
• Resolved: 01/Sep/15 02:21

Description

In functions: HierarchicalAllocatorProcess<RoleSorter, FrameworkSorter>::initialize() and HierarchicalAllocatorProcess<RoleSorter, FrameworkSorter>::allocate(), it does not need to check the roleSorter->count() , because the role * always be added to roleSorter.

So suggest to remove the following lines from initialize() and allocate() functions:

if (roleSorter>count() == 0)

{ - LOG(ERROR) << "No roles specified, cannot allocate resources!"; - return; -}