[MESOS-3044] Slaves are not deactivated upon reaching a maintenance window

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Component/s: master
• Labels: mesosphere
• Target Version/s: 0.24.0
• Epic Link: Maintenance
• Story Points: 8
• Assignee: Artem Harutyunyan
• Reporter: Joseph Wu
• Shepherd: Benjamin Hindman
• Created: 14/Jul/15 19:02
• Updated: 26/Nov/18 12:32
• Resolved: 26/Nov/18 12:32

Description

After a maintenance window is reached, the slave should be deactivated to prevent further tasks from utilizing it.

• For slaves that have completely drained, simply deactivate the slave. See Master::deactivate(Slave*).
• For tasks which have not explicitly declined the InverseOffers (i.e. they've accepted them or do not understand InverseOffers), send kill signals. See Master::killTask
• If a slave has tasks that have declined the InverseOffers, do not deactivate the slave.

Possible test(s):

• SlaveDrainedTest
  • Start master, slave.
  • Set maintenance to now.
  • Check that slave gets deactivated
• InverseOfferAgnosticTest
  • Start master, slave, framework.
  • Have a task run on the slave (ignores InverseOffers).
  • Set maintenance to now.
  • Check that task gets killed.
  • Check that slave gets deactivated.
• InverseOfferAcceptanceTest
  • Start master, slave, framework.
  • Run a task on the slave.
  • Set maintenance to future.
  • Have task accept InverseOffer.
  • Check task gets killed, slave gets deactivated.
• InverseOfferDeclinedTest
  • Start master, slave, framework.
  • Run task on slave.
  • Set maintenance to future.
  • Have task decline maintenance with reason.
  • Check task lives, slave still active.

Issue Links

• is blocked by: MESOS-3042 Master/Allocator does not send InverseOffers to resources to be maintained
• Is contained by: MESOS-2076 Implement maintenance primitives in the Master.