Mesos
  1. Mesos
  2. MESOS-285

configure.macosx checks for version "10.7" but should check for 10.7 or greater

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.0, 0.10.0, 0.11.0
    • Fix Version/s: 0.12.0
    • Component/s: build
    • Labels:
      None
    • Environment:

      Mac OS X Mountain Lion

      Description

      Starting in OS X 10.7 (Lion) the location of jni.h is different. The configure.macosx addresses this by checking for version 10.7 and adding the new location to JAVA_CPPFLAGS. However, the check currently only tests for version 10.7 when it should check for 10.7 or greater. See the exact line I'm talking about in the current head of trunk at https://github.com/apache/mesos/blob/fcc113f93113a32b26e668b7d27b1110e72a7dac/configure.macosx#L6

      if test ! -z `sw_vers -productVersion | grep 10.7`; then

      I believe a fix would be to have this line instead use Bash's extended test command (as suggested in the comment by user "Steev" on this blog post http://bkhome.org/blog/?viewDetailed=02199) which can compare dotted version numbers:

      osx_version=`sw_vers -productVersion`
      if [[ "$osx_version" == "10.7" || "$osx_version" > "10.7" ]]; then

      At least, this seems to work for me on 10.8.1 (Mountain Lion).

        Activity

        Andy Konwinski created issue -
        Hide
        Benjamin Mahler added a comment -

        I've bundled a fix for this in a review I just sent out: https://reviews.apache.org/r/8026/

        Show
        Benjamin Mahler added a comment - I've bundled a fix for this in a review I just sent out: https://reviews.apache.org/r/8026/
        Benjamin Mahler made changes -
        Field Original Value New Value
        Assignee Benjamin Mahler [ bmahler ]
        Mark Thomas made changes -
        Workflow jira [ 12727312 ] Mesos workflow [ 12741240 ]
        Hide
        Benjamin Mahler added a comment -
        Show
        Benjamin Mahler added a comment - Fixed committed: https://reviews.apache.org/r/8026
        Benjamin Mahler made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Chris A. Mattmann made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Benjamin Mahler [ bmahler ] Chris A. Mattmann [ chrismattmann ]
        Chris A. Mattmann made changes -
        Fix Version/s 0.9.0 [ 12319875 ]
        Chris A. Mattmann made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Vinod Kone made changes -
        Fix Version/s 0.10.0 [ 12324389 ]
        Fix Version/s 0.9.0 [ 12319875 ]
        Benjamin Mahler made changes -
        Affects Version/s 0.11.0 [ 12324390 ]
        Affects Version/s 0.10.0 [ 12324389 ]
        Benjamin Mahler made changes -
        Fix Version/s 0.12.0 [ 12324391 ]
        Fix Version/s 0.10.0 [ 12324389 ]
        Benjamin Mahler made changes -
        Assignee Chris A. Mattmann [ chrismattmann ] Benjamin Mahler [ bmahler ]

          People

          • Assignee:
            Benjamin Mahler
            Reporter:
            Andy Konwinski
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development