Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-2643

Python scheduler driver disables implicit acknowledgments by default.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.1
    • Component/s: python api
    • Labels:
      None

      Description

      Unfortunately, when introducing the ability to disable implicit acknowledgements, we accidentally disabled them by default for Python schedulers.

      int MesosSchedulerDriverImpl_init(MesosSchedulerDriverImpl* self,
                                        PyObject* args,
                                        PyObject* kwds)
      {
        // Note: We use an integer for 'implicitAcknoweldgements' because
        // it is the recommended way to pass booleans through CPython.
        PyObject* schedulerObj = NULL;
        PyObject* frameworkObj = NULL;
        const char* master;
        int implicitAcknowledgements; // XXX Should be set to 1 by default!
        PyObject* credentialObj = NULL;
      
        if (!PyArg_ParseTuple(
            args,
            "OOs|iO",
            &schedulerObj,
            &frameworkObj,
            &master,
            &implicitAcknowledgements,
            &credentialObj)) {
          return -1;
        }
      

      The default should be to preserve backwards compatibility, by enabling implicit acknowledgments.

        Issue Links

          Activity

          Hide
          bmahler Benjamin Mahler added a comment -
          commit c36d5996327ca765f49c211d489371c99ef8e090
          Author: Benjamin Mahler <benjamin.mahler@gmail.com>
          Date:   Wed Apr 22 14:28:46 2015 -0700
          
              Fixed the python bindings to use implicit acknoweldgements by default.
          
              Review: https://reviews.apache.org/r/33452
          
          Show
          bmahler Benjamin Mahler added a comment - commit c36d5996327ca765f49c211d489371c99ef8e090 Author: Benjamin Mahler <benjamin.mahler@gmail.com> Date: Wed Apr 22 14:28:46 2015 -0700 Fixed the python bindings to use implicit acknoweldgements by default. Review: https://reviews.apache.org/r/33452
          Show
          bmahler Benjamin Mahler added a comment - https://reviews.apache.org/r/33452/

            People

            • Assignee:
              bmahler Benjamin Mahler
              Reporter:
              bmahler Benjamin Mahler
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development