[MESOS-2643] Python scheduler driver disables implicit acknowledgments by default.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.22.1
• Component/s: python api
• Target Version/s: 0.22.1
• Assignee: Benjamin Mahler
• Reporter: Benjamin Mahler
• Created: 22/Apr/15 21:05
• Updated: 22/Apr/15 21:59
• Resolved: 22/Apr/15 21:58

Description

Unfortunately, when introducing the ability to disable implicit acknowledgements, we accidentally disabled them by default for Python schedulers.

int MesosSchedulerDriverImpl_init(MesosSchedulerDriverImpl* self,
                                  PyObject* args,
                                  PyObject* kwds)
{
  // Note: We use an integer for 'implicitAcknoweldgements' because
  // it is the recommended way to pass booleans through CPython.
  PyObject* schedulerObj = NULL;
  PyObject* frameworkObj = NULL;
  const char* master;
  int implicitAcknowledgements; // XXX Should be set to 1 by default!
  PyObject* credentialObj = NULL;

  if (!PyArg_ParseTuple(
      args,
      "OOs|iO",
      &schedulerObj,
      &frameworkObj,
      &master,
      &implicitAcknowledgements,
      &credentialObj)) {
    return -1;
  }

The default should be to preserve backwards compatibility, by enabling implicit acknowledgments.

Issue Links

• blocks: MESOS-2579 0.22.1 release