[MESOS-2569] Introduce Buffer abstraction to minimize inline buffer size constants, allocation and safe-guards

• Type: Improvement
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Labels: tech-debt
• Assignee: Unassigned
• Reporter: Niklas Quarfot Nielsen
• Created: 27/Mar/15 23:53
• Updated: 24/May/17 17:04

Description

We tend to have code (mostly in libprocess) like:

  if (socket.isReady()) {
    // Inform the socket manager for proper bookkeeping.
    socket_manager->accepted(socket.get());

    const size_t size = 80 * 1024;
    char* data = new char[size];
    memset(data, 0, size);

We can introduce a Buffer abstraction to stout which hides the pointers and helps initializing, copying, etc. This should make those buffers less error prone too.

Issue Links

• relates to: MESOS-2412 Potential memleak(s) in stout/os.hpp
• links to: r/31489