[MESOS-2519] Log IP addresses from HTTP requests

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.23.0
• Labels: twitter
• Sprint: Twitter Q2 Sprint 2, Twitter Mesos Q2 Sprint 5
• Story Points: 3
• Assignee: Benjamin Mahler
• Reporter: Daniel Robinson
• Shepherd: Vinod Kone
• Created: 19/Mar/15 19:22
• Updated: 15/Jun/15 23:19
• Resolved: 15/Jun/15 22:44

Description

Querying /master/state.json is an expensive operation when a cluster is large, and it's possible to DOS the master via frequent and repeated queries (which is a separate problem). Querying the endpoint results in a log entry being written, but the entry lacks useful information, such as an IP address, response code and response size. These details are useful for tracking down who/what is querying the endpoint. Consider adding these details to the log entry, or even writing a separate access log. Also consider writing log entries for all HTTP requests (/metrics/snapshot produces no log entries).

sample log entry

I0319 18:06:18.824846 10521 http.cpp:478] HTTP request for '/master/state.json'

Issue Links

• supercedes: MESOS-1096 Add IP address to HTTP request logging