[MESOS-2463] Slaves sends mutated copy of executorinfo to new elected master

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.22.0
• Fix Version/s: 0.22.0
• Labels: mesosphere
• Target Version/s: 0.22.0
• Sprint: Mesosphere Q1 Sprint 5 - 3/20
• Assignee: Kapil Arya
• Reporter: Chi Zhang
• Created: 06/Mar/15 23:02
• Updated: 08/Aug/15 00:16
• Resolved: 12/Mar/15 00:35

Description

static ExecutorInfo decorateExecutorEnvironment(
    ExecutorInfo executorInfo,
    const TaskInfo& taskInfo)
{
  // Merge environment variables retrieved from label-decorator hooks.
  executorInfo.mutable_command()->mutable_environment()->MergeFrom(
      HookManager::slaveLaunchExecutorEnvironmentDecorator(
          executorInfo,
          taskInfo));

  return executorInfo;
}

does a default allocation of environment, even when the original ExecutorInfo doesn't have one set.

When a new master is elected and receives this copy, it would reject tasks for the same Executor because of this difference:

Existing ExecutorInfo has :
command

{ uris { value: "/usr/local/bin/gc_executor" executable: true }

environment

{ } value: "./gc_executor" } framework_id { value: "201103282247-0000000019-0000" }

------------------------------------------------------------
New Task's ExecutorInfo has:
command

{ uris { value: "/usr/local/bin/gc_executor" executable: true }

value: "./gc_executor"
}
framework_id

{ value: "201103282247-0000000019-0000" }

Issue Links

• relates to: MESOS-3003 Support mounting in default configuration files/volumes into every new container