Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-1770

Docker with command shell=true should override entrypoint

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.20.1
    • Component/s: None
    • Labels:

      Description

      Currently with the new CommandInfo there is a shell flag that if it's enabled, will wrap the command with /bin/sh -c with docker run.

      However we don't override the entrypoint, therefore when a user specified a image with a entrypoint and also have shell=true then /bin/sh -c will become part of the argument to the entrypoint.

      I don't think there is any example where users expect /bin/sh -c to be a argument in the entrypoint, and to make sure cases where shell is needed for expanding environment variables we also override the entrypoint.

        Activity

        Hide
        benjaminhindman Benjamin Hindman added a comment -

        commit cc9fd81243bdcbf468a2d8cbcb22e6527335bf00
        Author: Timothy Chen <tnachen@apache.org>
        Date: Wed Sep 17 08:49:38 2014 -0700

        Override entrypoint when shell enabled in Docker.

        Review: https://reviews.apache.org/r/25403

        Show
        benjaminhindman Benjamin Hindman added a comment - commit cc9fd81243bdcbf468a2d8cbcb22e6527335bf00 Author: Timothy Chen <tnachen@apache.org> Date: Wed Sep 17 08:49:38 2014 -0700 Override entrypoint when shell enabled in Docker. Review: https://reviews.apache.org/r/25403
        Hide
        bhuvan Bhuvan Arumugam added a comment -

        Timothy Chen the above patch break the build. can you please fix and post a revised patch?

        Show
        bhuvan Bhuvan Arumugam added a comment - Timothy Chen the above patch break the build. can you please fix and post a revised patch?
        Hide
        tnachen Timothy Chen added a comment -
        Show
        tnachen Timothy Chen added a comment - Reviewboard: https://reviews.apache.org/r/25403/

          People

          • Assignee:
            tnachen Timothy Chen
            Reporter:
            tnachen Timothy Chen
            Shepherd:
            Benjamin Hindman
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development