Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-1055

Add explicit to single argument constructors

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.19.0
    • Component/s: c++ api
    • Labels:

      Description

      From the google style guide:

      Normally, if a constructor takes one argument, it can be used as a conversion. For instance, if you define Foo::Foo(string name) and then pass a string to a function that expects a Foo, the constructor will be called to convert the string into a Foo and will pass the Foo to your function for you. This can be convenient but is also a source of trouble when things get converted and new objects created without you meaning them to. Declaring a constructor explicit prevents it from being invoked implicitly as a conversion.

      Implicit conversions should be the exception to avoid unwanted and unexpected behaviour.

        Attachments

          Activity

            People

            • Assignee:
              bernd-mesos Bernd Mathiske
              Reporter:
              dhamon Dominic Hamon
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: