[MESOS-10216] Replicated log key encoding overflows into negative values

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.3, 1.8.1, 1.9.1, 1.11.0, 1.10.1, 1.12.0
• Fix Version/s: 1.12.0
• Component/s: replicated log
• External issue URL: https://github.com/apache/mesos/pull/386
• Assignee: Charles Natali
• Reporter: Ilya
• Shepherd: Andrei Sekretenko
• Created: 25/Mar/21 21:38
• Updated: 18/Jun/21 06:05
• Resolved: 18/Jun/21 06:05

Description

LevelDB keys used by LevelDBStorage are uint64_t log positions encoded as strings and padded with zeroes up to a certain fixed size. The encode() function is incorrect because it uses the %d formatter that expects an int. It also limits the key size to 10 digits which is OK for UINT32_MAX but isn't enough for UINT64_MAX.

Because of this the available key range is reduced, and key overflow can result in replica's METADATA record (position 0) being overwritten, which in turn may cause data loss.