Uploaded image for project: 'Maven Enforcer Plugin'
  1. Maven Enforcer Plugin
  2. MENFORCER-228

DependencyConvergence: Simplify logging errors

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 3.0.0-M1, 3.0.0-M2, 3.0.0
    • Component/s: Standard Rules
    • Labels:
      None
    • Environment:
      Maven 3.2.2; Oracle JDK 8

      Description

      The dependency convergence rule check works great. I just wonder if it is really necessary to log the according error messages two times:

      see source code http://svn.apache.org/viewvc/maven/enforcer/tags/1.4/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/DependencyConvergence.java?view=markup

      lines 127 to 134
      for ( CharSequence errorMsg : errorMsgs )
      {
       	log.warn( errorMsg );
      }
      if ( errorMsgs.size() > 0 )
      {
       	throw new EnforcerRuleException( "Failed while enforcing releasability the error(s) are " + errorMsgs );
      }
      

      this produces outputs like:

      [INFO] --- maven-enforcer-plugin:1.4:enforce (enforce dependency convergence) @ bom ---
      [WARNING] 
      Dependency convergence error for commons-logging:commons-logging:1.1.3 paths to dependency are:
      +-my.group:my.artifact:2.1-SNAPSHOT
        +-org.springframework:spring-context:4.0.9.RELEASE
          +-org.springframework:spring-core:4.0.9.RELEASE
            +-commons-logging:commons-logging:1.1.3
      and
      +-my.group:my.artifact:2.1-SNAPSHOT
        +-com.orientechnologies:orientdb-graphdb:2.1-rc1
          +-com.tinkerpop.blueprints:blueprints-core:2.6.0
            +-commons-logging:commons-logging:1.1.1
      
      [WARNING] 
      Dependency convergence error for org.slf4j:jcl-over-slf4j:1.7.6 paths to dependency are:
      +-my.group:my.artifact:2.1-SNAPSHOT
        +-org.activiti:activiti-engine:5.17.0
          +-org.activiti:activiti-bpmn-converter:5.17.0
            +-org.slf4j:jcl-over-slf4j:1.7.6
      and
      +-my.group:my.artifact:2.1-SNAPSHOT
        +-org.activiti:activiti-engine:5.17.0
          +-org.slf4j:jcl-over-slf4j:1.7.6
      and
      +-my.group:my.artifact:2.1-SNAPSHOT
        +-org.springframework.ldap:spring-ldap-core:2.0.2.RELEASE
          +-org.springframework.data:spring-data-commons:1.6.1.RELEASE
            +-org.slf4j:jcl-over-slf4j:1.7.1
      
      [WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
      Failed while enforcing releasability the error(s) are [
      Dependency convergence error for commons-logging:commons-logging:1.1.3 paths to dependency are:
      +-my.group:my.artifact:2.1-SNAPSHOT
        +-org.springframework:spring-context:4.0.9.RELEASE
          +-org.springframework:spring-core:4.0.9.RELEASE
            +-commons-logging:commons-logging:1.1.3
      and
      +-my.group:my.artifact:2.1-SNAPSHOT
        +-com.orientechnologies:orientdb-graphdb:2.1-rc1
          +-com.tinkerpop.blueprints:blueprints-core:2.6.0
            +-commons-logging:commons-logging:1.1.1
      , 
      Dependency convergence error for org.slf4j:jcl-over-slf4j:1.7.6 paths to dependency are:
      +-my.group:my.artifact:2.1-SNAPSHOT
        +-org.activiti:activiti-engine:5.17.0
          +-org.activiti:activiti-bpmn-converter:5.17.0
            +-org.slf4j:jcl-over-slf4j:1.7.6
      and
      +-my.group:my.artifact:2.1-SNAPSHOT
        +-org.activiti:activiti-engine:5.17.0
          +-org.slf4j:jcl-over-slf4j:1.7.6
      and
      +-my.group:my.artifact:2.1-SNAPSHOT
        +-org.springframework.ldap:spring-ldap-core:2.0.2.RELEASE
          +-org.springframework.data:spring-data-commons:1.6.1.RELEASE
            +-org.slf4j:jcl-over-slf4j:1.7.1
      ]
      

      the warning log messages are identical to the messages of the exception. so just skip one of the outputs if possible.

        Attachments

          Activity

            People

            • Assignee:
              khmarbaise Karl Heinz Marbaise
              Reporter:
              krulls Stephan Krull
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: